fix(gha): use regctl for (multiarch) image copy #10335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
dndx
requested changes
Feb 22, 2023
dndx
approved these changes
Feb 22, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.2.x release/3.2.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.2.x
# Create a new branch
git switch --create backport-10335-to-release/3.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b5d01ecbcfe6c990f49cee4d8279b4b4267c0373
# Push it to GitHub
git push --set-upstream origin backport-10335-to-release/3.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.2.xThen, create a pull request where the |
dndx
added a commit
that referenced
this pull request
Feb 22, 2023
Co-authored-by: Datong Sun <datong.sun@konghq.com>
dndx
added a commit
that referenced
this pull request
Feb 23, 2023
Co-authored-by: Datong Sun <datong.sun@konghq.com>
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
This relates to this Pongo release PR: Kong/kong-pongo#627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR pivots the docker hub re-tagging portions of the release github action to utilize
regctl image copyinstead of plain ole'docker pull.The
docker pullapproach lacked support for multi-architecture builds, result in onlyamd64image tags being added to unofficial/official repos.Sister PR to: https://github.com/Kong/kong-ee/pull/4624
Checklist
Full changelog
Issue reference
Fix #[issue number]